Refactor calendar sync for parallel processing: cron emits per-employee events, event-step processes one employee with per-employee locks

bitbylaw/steps/advoware_cal_sync/calendar_sync_cron_step.py

@@ -3,77 +3,70 @@ import redis
 from config import Config
 from services.advoware import AdvowareAPI
 
-async def get_advoware_employees(advoware, logger):
-    """Fetch list of employees from Advoware."""
-    try:
-        result = await advoware.api_call('api/v1/advonet/Mitarbeiter', method='GET', params={'aktiv': 'true'})
-        employees = result if isinstance(result, list) else []
-        logger.info(f"Fetched {len(employees)} Advoware employees")
-        return employees
-    except Exception as e:
-        logger.error(f"Failed to fetch Advoware employees: {e}")
-        raise
+CALENDAR_SYNC_LOCK_KEY = 'calendar_sync_lock'
+
+config = {
     'type': 'cron',
     'name': 'Calendar Sync Cron Job',
     'description': 'Führt den Calendar Sync alle 15 Minuten automatisch aus',
     'cron': '*/15 * * * *',  # Alle 15 Minuten
-    'emits': ['calendar.sync.triggered']
+    'emits': ['calendar.sync.employee']
 }
 
+async def get_advoware_employees(advoware):
+    """Fetch list of employees from Advoware."""
+    try:
+        result = await advoware.api_call('api/v1/advonet/Mitarbeiter', method='GET', params={'aktiv': 'true'})
+        employees = result if isinstance(result, list) else []
+        context.logger.info(f"Fetched {len(employees)} Advoware employees")
+        return employees
+    except Exception as e:
+        context.logger.error(f"Failed to fetch Advoware employees: {e}")
+        raise
+
 async def handler(context):
     try:
-        context.logger.info("Calendar Sync Cron: Starting automatic synchronization every 15 minutes")
+        context.logger.info("Calendar Sync Cron: Starting to fetch employees and emit events")
 
         # Initialize Advoware API
         advoware = AdvowareAPI(context)
 
-        # Fetch all employees
-        employees = await get_advoware_employees(advoware, context.logger)
+        # Fetch employees
+        employees = await get_advoware_employees(advoware)
         if not employees:
-            context.logger.error("Calendar Sync Cron: No employees found. Sync cancelled.")
-            return {
-                'status': 'error',
-                'reason': 'no_employees',
-                'triggered_by': 'cron'
-            }
+            context.logger.error("Keine Mitarbeiter gefunden. Cron abgebrochen.")
+            return {'status': 500, 'body': {'error': 'Keine Mitarbeiter gefunden'}}
 
-        total_emitted = 0
+        # Emit event for each employee (DEBUG: only for SB)
         for employee in employees:
             kuerzel = employee.get('kuerzel')
             if not kuerzel:
-                context.logger.warning(f"Calendar Sync Cron: Employee without kuerzel skipped: {employee}")
+                context.logger.warning(f"Mitarbeiter ohne Kürzel übersprungen: {employee}")
                 continue
 
-            # DEBUG: Limit to SB for debugging
+            # DEBUG: Nur für Nutzer SB syncen
             if kuerzel != 'SB':
-                context.logger.info(f"Calendar Sync Cron: DEBUG: Skipping {kuerzel}, only SB synced")
+                context.logger.info(f"DEBUG: Überspringe {kuerzel}, nur SB wird gesynct")
                 continue
 
-            context.logger.info(f"Calendar Sync Cron: Emitting sync event for {kuerzel}")
-
-            # Emit Event for the Sync with kuerzel
+            # Emit event for this employee
             await context.emit({
-                "topic": "calendar.sync.triggered",
+                "topic": "calendar.sync.employee",
                 "data": {
-                    "body": {
-                        "kuerzel": kuerzel,
-                        "full_content": True,  # Cron uses always full details
-                        "triggered_by": "cron"
-                    }
+                    "kuerzel": kuerzel,
+                    "triggered_by": "cron"
                 }
             })
+            context.logger.info(f"Calendar Sync Cron: Emitted event for employee {kuerzel}")
 
-            total_emitted += 1
-
-        context.logger.info(f"Calendar Sync Cron: Emitted {total_emitted} sync events")
+        context.logger.info("Calendar Sync Cron: Completed emitting events for employees")
         return {
             'status': 'completed',
-            'total_emitted': total_emitted,
             'triggered_by': 'cron'
         }
 
     except Exception as e:
-        context.logger.error(f"Calendar Sync Cron: Error in cron job: {e}")
+        context.logger.error(f"Fehler beim Cron-Job: {e}")
         return {
             'status': 'error',
             'error': str(e)