Refactor calendar sync: move employee loop to cron step, parallel sync per employee

bitbylaw/steps/advoware_cal_sync/calendar_sync_cron_step.py

@@ -1,10 +1,18 @@
 import json
 import redis
 from config import Config
+from services.advoware import AdvowareAPI
 
-CALENDAR_SYNC_LOCK_KEY = 'calendar_sync_lock'
-
-config = {
+async def get_advoware_employees(advoware, logger):
+    """Fetch list of employees from Advoware."""
+    try:
+        result = await advoware.api_call('api/v1/advonet/Mitarbeiter', method='GET', params={'aktiv': 'true'})
+        employees = result if isinstance(result, list) else []
+        logger.info(f"Fetched {len(employees)} Advoware employees")
+        return employees
+    except Exception as e:
+        logger.error(f"Failed to fetch Advoware employees: {e}")
+        raise
     'type': 'cron',
     'name': 'Calendar Sync Cron Job',
     'description': 'Führt den Calendar Sync alle 15 Minuten automatisch aus',
@@ -14,45 +22,58 @@ config = {
 
 async def handler(context):
     try:
-        # Prüfe ob bereits ein Sync läuft
-        redis_client = redis.Redis(
-            host=Config.REDIS_HOST,
-            port=int(Config.REDIS_PORT),
-            db=int(Config.REDIS_DB_CALENDAR_SYNC),
-            socket_timeout=Config.REDIS_TIMEOUT_SECONDS
-        )
-        
-        if redis_client.get(CALENDAR_SYNC_LOCK_KEY):
-            context.logger.info("Calendar Sync Cron: Sync bereits aktiv, überspringe")
+        context.logger.info("Calendar Sync Cron: Starting automatic synchronization every 15 minutes")
+
+        # Initialize Advoware API
+        advoware = AdvowareAPI(context)
+
+        # Fetch all employees
+        employees = await get_advoware_employees(advoware, context.logger)
+        if not employees:
+            context.logger.error("Calendar Sync Cron: No employees found. Sync cancelled.")
             return {
-                'status': 'skipped',
-                'reason': 'sync_already_running',
+                'status': 'error',
+                'reason': 'no_employees',
                 'triggered_by': 'cron'
             }
-        
-        # Setze Lock für 30 Minuten (Sync sollte max 30 Minuten dauern)
-        redis_client.set(CALENDAR_SYNC_LOCK_KEY, 'cron', ex=1800)
-        context.logger.info("Calendar Sync Cron: Lock gesetzt, starte automatische Synchronisation alle 15 Minuten")
 
-        # Emit Event für den Sync
-        await context.emit({
-            "topic": "calendar.sync.triggered",
-            "data": {
-                "body": {
-                    "full_content": True,  # Cron verwendet immer volle Details
-                    "triggered_by": "cron"
+        total_emitted = 0
+        for employee in employees:
+            kuerzel = employee.get('kuerzel')
+            if not kuerzel:
+                context.logger.warning(f"Calendar Sync Cron: Employee without kuerzel skipped: {employee}")
+                continue
+
+            # DEBUG: Limit to SB for debugging
+            if kuerzel != 'SB':
+                context.logger.info(f"Calendar Sync Cron: DEBUG: Skipping {kuerzel}, only SB synced")
+                continue
+
+            context.logger.info(f"Calendar Sync Cron: Emitting sync event for {kuerzel}")
+
+            # Emit Event for the Sync with kuerzel
+            await context.emit({
+                "topic": "calendar.sync.triggered",
+                "data": {
+                    "body": {
+                        "kuerzel": kuerzel,
+                        "full_content": True,  # Cron uses always full details
+                        "triggered_by": "cron"
+                    }
                 }
-            }
-        })
+            })
 
-        context.logger.info("Calendar Sync Cron: Event wurde emittiert")
+            total_emitted += 1
+
+        context.logger.info(f"Calendar Sync Cron: Emitted {total_emitted} sync events")
         return {
             'status': 'completed',
+            'total_emitted': total_emitted,
             'triggered_by': 'cron'
         }
 
     except Exception as e:
-        context.logger.error(f"Fehler beim Cron-Job: {e}")
+        context.logger.error(f"Calendar Sync Cron: Error in cron job: {e}")
         return {
             'status': 'error',
             'error': str(e)