fix: add try/finally for lock release in bankverbindungen_sync handler – prevents 15-min lock leaks on exception

src/steps/crm/bankverbindungen/bankverbindungen_sync_event_step.py

@@ -55,9 +55,10 @@ async def handler(event_data: Dict[str, Any], ctx: FlowContext[Any]) -> None:
     mapper = BankverbindungenMapper()
     notification_mgr = NotificationManager(espocrm_api=espocrm, context=ctx)
     
+    lock_key = f"sync_lock:cbankverbindungen:{entity_id}"
+    acquired = False
     try:
         # 1. ACQUIRE LOCK
-        lock_key = f"sync_lock:cbankverbindungen:{entity_id}"
         acquired = redis_client.set(lock_key, "locked", nx=True, ex=900)  # 15min TTL
 
         if not acquired:
@@ -69,7 +70,6 @@ async def handler(event_data: Dict[str, Any], ctx: FlowContext[Any]) -> None:
             espo_entity = await espocrm.get_entity('CBankverbindungen', entity_id)
         except Exception as e:
             ctx.logger.error(f"❌ Fehler beim Laden von EspoCRM Entity: {e}")
-            redis_client.delete(lock_key)
             return
 
         ctx.logger.info(f"📋 Entity geladen: {espo_entity.get('name', 'Unbenannt')} (IBAN: {espo_entity.get('iban', 'N/A')})")
@@ -79,7 +79,6 @@ async def handler(event_data: Dict[str, Any], ctx: FlowContext[Any]) -> None:
 
         if not beteiligte_id:
             ctx.logger.error(f"❌ Keine cBeteiligteId gefunden - Bankverbindung muss einem Beteiligten zugeordnet sein")
-            redis_client.delete(lock_key)
             return
 
         # Hole betNr vom Parent
@@ -88,7 +87,6 @@ async def handler(event_data: Dict[str, Any], ctx: FlowContext[Any]) -> None:
 
         if not betnr:
             ctx.logger.error(f"❌ Parent Beteiligter {beteiligte_id} hat keine betNr")
-            redis_client.delete(lock_key)
             return
 
         # 3. BESTIMME SYNC-AKTION
@@ -107,17 +105,19 @@ async def handler(event_data: Dict[str, Any], ctx: FlowContext[Any]) -> None:
 
         else:
             ctx.logger.warn(f"⚠️  Unbekannte Kombination: action={action}, advowareId={advoware_id}")
-            redis_client.delete(lock_key)
 
     except Exception as e:
         ctx.logger.error(f"❌ Unerwarteter Fehler im Sync-Handler: {e}")
         import traceback
         ctx.logger.error(traceback.format_exc())
+        raise
 
-        try:
-            redis_client.delete(lock_key)
-        except:
-            pass
+    finally:
+        if acquired:
+            try:
+                redis_client.delete(lock_key)
+            except Exception as cleanup_err:
+                ctx.logger.error(f"❌ Lock-Release fehlgeschlagen: {cleanup_err}")
 
 
 async def handle_create(entity_id, betnr, espo_entity, espocrm, advoware, mapper, ctx, redis_client, lock_key) -> None: